Merge with develop

--HG--
branch : compatibility-develop
This commit is contained in:
Nimetu 2017-01-10 15:09:55 +02:00
commit ab5aa5b2c4
2 changed files with 41 additions and 11 deletions

View file

@ -588,11 +588,25 @@ namespace NLGUI
// second instance deletes first tmpfile and creates new file for itself. // second instance deletes first tmpfile and creates new file for itself.
if (CFile::getFileSize(tmpfile) > 0) if (CFile::getFileSize(tmpfile) > 0)
{ {
CFile::moveFile(it->dest, tmpfile); try
for(uint i = 0; i < it->imgs.size(); i++)
{ {
setImage(it->imgs[i].Image, it->dest); // verify that image is not corrupted
setImageSize(it->imgs[i].Image, it->imgs[i].Style); uint32 w, h;
CBitmap::loadSize(tmpfile, w, h);
if (w != 0 && h != 0)
{
CFile::moveFile(it->dest, tmpfile);
for(uint i = 0; i < it->imgs.size(); i++)
{
setImage(it->imgs[i].Image, it->dest);
setImageSize(it->imgs[i].Image, it->imgs[i].Style);
}
}
}
catch(const NLMISC::Exception &e)
{
// exception message has .tmp file name, so keep it for further analysis
nlwarning("Invalid image (%s): %s", it->url.c_str(), e.what());
} }
} }
} }
@ -4177,10 +4191,18 @@ namespace NLGUI
if (!reloadImg && lookupLocalFile (finalUrl, image.c_str(), false)) if (!reloadImg && lookupLocalFile (finalUrl, image.c_str(), false))
{ {
// don't display image that are not power of 2 // don't display image that are not power of 2
uint32 w, h; try
CBitmap::loadSize (image, w, h); {
if (w == 0 || h == 0 || ((!NLMISC::isPowerOf2(w) || !NLMISC::isPowerOf2(h)) && !NL3D::CTextureFile::supportNonPowerOfTwoTextures())) uint32 w, h;
CBitmap::loadSize (image, w, h);
if (w == 0 || h == 0 || ((!NLMISC::isPowerOf2(w) || !NLMISC::isPowerOf2(h)) && !NL3D::CTextureFile::supportNonPowerOfTwoTextures()))
image = "web_del.tga";
}
catch(const NLMISC::Exception &e)
{
nlwarning(e.what());
image = "web_del.tga"; image = "web_del.tga";
}
} }
else else
{ {
@ -4376,10 +4398,18 @@ namespace NLGUI
} }
else else
{ {
uint32 w, h; try
CBitmap::loadSize(normal, w, h); {
if (w == 0 || h == 0) uint32 w, h;
CBitmap::loadSize(normal, w, h);
if (w == 0 || h == 0)
normal = "web_del.tga";
}
catch(const NLMISC::Exception &e)
{
nlwarning(e.what());
normal = "web_del.tga"; normal = "web_del.tga";
}
} }
} }
} }

View file

@ -65,7 +65,7 @@ static int readGIFData(GifFileType *gif, GifByteType *data, int length)
} }
catch(...) catch(...)
{ {
nlwarning("error while reading JPEG image"); nlwarning("error while reading GIF image");
return 0; return 0;
} }