From 4f4ba7120d12d34c377cb4350715eeef1a7d54a4 Mon Sep 17 00:00:00 2001
From: Nimetu <nimetu@gmail.com>
Date: Fri, 3 May 2019 08:59:19 +0300
Subject: [PATCH] Changed: Set background image from html or body

--HG--
branch : develop
---
 code/nel/include/nel/gui/group_html.h |  3 +
 code/nel/src/gui/group_html.cpp       | 91 ++++++++++++++++-----------
 2 files changed, 59 insertions(+), 35 deletions(-)

diff --git a/code/nel/include/nel/gui/group_html.h b/code/nel/include/nel/gui/group_html.h
index 2c6737446..fc29c840d 100644
--- a/code/nel/include/nel/gui/group_html.h
+++ b/code/nel/include/nel/gui/group_html.h
@@ -816,6 +816,9 @@ namespace NLGUI
 		// :before, :after rendering
 		void renderPseudoElement(const std::string &pseudo, const CHtmlElement &elm);
 
+		// apply background from current style (for html, body)
+		void applyBackground(const CHtmlElement &elm);
+
 		// HTML elements
 		void htmlA(const CHtmlElement &elm);
 		void htmlAend(const CHtmlElement &elm);
diff --git a/code/nel/src/gui/group_html.cpp b/code/nel/src/gui/group_html.cpp
index e6f02b7b1..e11369014 100644
--- a/code/nel/src/gui/group_html.cpp
+++ b/code/nel/src/gui/group_html.cpp
@@ -3379,6 +3379,13 @@ namespace NLGUI
 				bitmap->setRenderLayer(-2);
 				bitmap->setScale(scale);
 				bitmap->setTile(tile);
+
+				// clear size ref for non-scaled image or it does not show up
+				if (scale || tile)
+					bitmap->setSizeRef("wh");
+				else
+					bitmap->setSizeRef("");
+
 				addImageDownload(bgtex, view);
 			}
 		}
@@ -5015,6 +5022,52 @@ namespace NLGUI
 		_CellParams.push_back (cellParams);
 	}
 
+	// ***************************************************************************
+	void CGroupHTML::applyBackground(const CHtmlElement &elm)
+	{
+		bool root = elm.Value == "html" || elm.Value == "body";
+
+		// non-empty image
+		if (_Style.hasStyle("background-image"))
+		{
+			// value '1' and 'background-scale' are ryzom only
+			bool repeat = _Style.checkStyle("background-repeat", "1") || _Style.checkStyle("background-repeat", "repeat");
+			bool scale = _Style.checkStyle("background-scale", "1") || _Style.checkStyle("background-size", "100% 100%");
+			std::string image = trim(_Style.getStyle("background-image"));
+			string::size_type texExt = toLower(image).find("url(");
+			if (texExt != string::npos)
+			{
+				image = image.substr(texExt+4, image.size()-texExt-5);
+			}
+			if (!image.empty())
+			{
+				if (root)
+				{
+					setBackground (image, scale, repeat);
+				}
+				// TODO: else
+
+				// default background color is transparent, so image does not show
+				if (!_Style.hasStyle("background-color"))
+				{
+					_Style.applyStyle("background-color: #fff;");
+				}
+			}
+		}
+
+		if (_Style.hasStyle("background-color"))
+		{
+			CRGBA bgColor = _Style.Current.BackgroundColor;
+			scanHTMLColor(elm.getAttribute("bgcolor").c_str(), bgColor);
+			if (root)
+			{
+				setBackgroundColor(bgColor);
+			}
+			// TODO: else 
+		}
+
+	}
+
 	// ***************************************************************************
 	void CGroupHTML::htmlA(const CHtmlElement &elm)
 	{
@@ -5084,39 +5137,7 @@ namespace NLGUI
 			_Style.applyStyle("background-color: " + elm.getAttribute("bgcolor"));
 		}
 
-		if (_Style.hasStyle("background-color"))
-		{
-			CRGBA bgColor = _Style.Current.BackgroundColor;
-			scanHTMLColor(elm.getAttribute("bgcolor").c_str(), bgColor);
-			setBackgroundColor(bgColor);
-		}
-
-		if (elm.hasNonEmptyAttribute("style"))
-		{
-			string style = elm.getAttribute("style");
-
-			TStyle styles = parseStyle(style);
-			TStyle::iterator	it;
-
-			it = styles.find("background-repeat");
-			bool repeat = (it != styles.end() && it->second == "1");
-
-			// Webig only
-			it = styles.find("background-scale");
-			bool scale = (it != styles.end() && it->second == "1");
-
-			it = styles.find("background-image");
-			if (it != styles.end())
-			{
-				string image = it->second;
-				string::size_type texExt = toLower(image).find("url(");
-				// Url image
-				if (texExt != string::npos)
-					// Remove url()
-					image = image.substr(4, image.size()-5);
-				setBackground (image, scale, repeat);
-			}
-		}
+		applyBackground(elm);
 
 		renderPseudoElement(":before", elm);
 	}
@@ -5468,7 +5489,7 @@ namespace NLGUI
 			_Style.applyRootStyle(elm.getAttribute("style"));
 			_Style.Current = _Style.Root;
 		}
-		setBackgroundColor(_Style.Current.BackgroundColor);
+		applyBackground(elm);
 	}
 
 	// ***************************************************************************
@@ -6278,7 +6299,7 @@ namespace NLGUI
 		if (_Style.checkStyle("background-repeat", "1") || _Style.checkStyle("background-repeat", "repeat"))
 			_Cells.back()->setTextureTile(true);
 
-		if (_Style.checkStyle("background-scale", "1") || _Style.checkStyle("background-size", "cover"))
+		if (_Style.checkStyle("background-scale", "1") || _Style.checkStyle("background-size", "100% 100%"))
 			_Cells.back()->setTextureScale(true);
 
 		if (_Style.hasStyle("background-image"))